Bug 66439 - [chromium] Remove LayerRendererChromium references from WebGLLayerChromium
Summary: [chromium] Remove LayerRendererChromium references from WebGLLayerChromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 66430
  Show dependency treegraph
 
Reported: 2011-08-17 17:46 PDT by Adrienne Walker
Modified: 2011-09-02 11:19 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-08-17 17:46:47 PDT
WebGLLayerChromium will need to keep its own context for drawing, but will need to use a compositor context passed in as a function arg during updateCompositorResources.

Similarly to bug 66435, the interaction with adding and removing child contexts from the LayerRendererChromium will need to be deferred.

The part that I don't fully understand is how to handle WebGLLayerChromium::paintRenderingResultsToCanvas.  That seems problematic at best to get working with the compositor thread.
Comment 1 James Robinson 2011-08-17 17:48:51 PDT
Yeah it's extremely problematic.  It's basically a hack to get printing going for m14. We need to figure this out for real going forward.
Comment 2 James Robinson 2011-08-18 11:05:50 PDT
I personally vote that we punt on threaded compositor + WebGL + printing for now.  It'll be a pain to sort out now, but I think it'll become more clear once we figure out how we handle readback paths in the threaded compositor in general.
Comment 3 Adrienne Walker 2011-08-18 11:09:21 PDT
(In reply to comment #2)
> I personally vote that we punt on threaded compositor + WebGL + printing for now.  It'll be a pain to sort out now, but I think it'll become more clear once we figure out how we handle readback paths in the threaded compositor in general.

In the short term maybe we can #ifdef this functionality out when the threaded compositor is on and file another bug to fix it properly.
Comment 4 Adrienne Walker 2011-09-02 11:19:16 PDT
This was fixed in bug 66430.