Bug 66430 – [chromium] Remove LayerRendererChromium references from the LayerChromium tree

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Adrienne Walker]

LayerRendererChromium is a compositor thread-side class that currently both LayerChromium- and CCLayerImpl-derived classes access, mostly to get at the context and settings.  LayerChromium::layerRenderer() and LayerChromium::layerRendererContext() should both be removed, once alternate functionality is put in place for all of the LayerChromium-derived classes.

[Adrienne Walker]

Created attachment 106011 [details]
Patch

[Adrienne Walker]

This needs bug 66807 to land before this patch will apply, so leaving the review flag off.

nduca: I'd love if you could sanity check what I did in WebGLLayerChromium to punch through the compositor context in the single-threaded case.  I used a bunch of functions that looked like they were temporary and would eventually go away.  If you have a better idea about how to do this, I'll take suggestions.  :)

[Adrienne Walker]

Created attachment 106013 [details]
Patch

[Nat Duca]

Comment on attachment 106013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106013&action=review

Me <3's this patch.

> Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:152
> +    return 0;

ASSERT(false); CRASH()

[Adrienne Walker]

Created attachment 106059 [details]
Patch

[James Robinson]

Comment on attachment 106059 [details]
Patch

R=me

[Nat Duca]

Comment on attachment 106059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106059&action=review

> Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:149
> +#if USE(THREADED_COMPOSITING)

Sorry for the late breaking feedback, but can we do this as a runtime check? E.g. layerTreeHost()->settings().useThreadedCompositing

[Adrienne Walker]

(In reply to comment #7)
> (From update of attachment 106059 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106059&action=review
> 
> > Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp:149
> > +#if USE(THREADED_COMPOSITING)
> 
> Sorry for the late breaking feedback, but can we do this as a runtime check? E.g. layerTreeHost()->settings().useThreadedCompositing

Ah, you're totally right.  I'll fix that when landing.

[Adrienne Walker]

Committed r94431: <http://trac.webkit.org/changeset/94431>