Bug 66435 - [chromium] Remove LayerRendererChromium references from Canvas2DLayerChromium
Summary: [chromium] Remove LayerRendererChromium references from Canvas2DLayerChromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 66743
Blocks: 66430
  Show dependency treegraph
 
Reported: 2011-08-17 17:08 PDT by Adrienne Walker
Modified: 2011-08-23 17:46 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-08-17 17:08:26 PDT
LayerRendererChromium is a compositor thread-side class, so Canvas(2D)LayerChromium should not have access to it, except during updateCompositorResources.  The DrawingBuffer creation and destruction and its interaction with the LRC are probably the largest problems here.  The removal and addition of child contexts will have to be deferred until the next commit and stored somewhere (CCLayerTreeHost?).
Comment 1 Adrienne Walker 2011-08-17 17:14:19 PDT
Also, maybe setDrawingBuffer could be removed, as it doesn't seem to be used anywhere except to clear the drawing buffer in some other class's destructor.
Comment 2 James Robinson 2011-08-18 11:07:42 PDT
I don't think we actually need the child context stuff any more, that was for some latching code that's redundant now.  I'll confirm that with Bates.
Comment 3 James Robinson 2011-08-23 17:46:22 PDT
I think we're good here now, DrawingBuffer only touches the canvas context (not the compositor context) and there's no child context stuff any more.  Marking as fixed.