Bug 66743 - [chromium] Remove obsolete child context list from LayerRendererChromium
Summary: [chromium] Remove obsolete child context list from LayerRendererChromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks: 66435
  Show dependency treegraph
 
Reported: 2011-08-22 18:41 PDT by James Robinson
Modified: 2011-08-23 16:01 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.78 KB, patch)
2011-08-22 18:43 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-08-22 18:41:08 PDT
[chromium] Remove obsolete child context list from LayerRendererChromium
Comment 1 James Robinson 2011-08-22 18:43:24 PDT
Created attachment 104781 [details]
Patch
Comment 2 John Bates 2011-08-22 18:52:30 PDT
Comment on attachment 104781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104781&action=review

My precious codez!

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:-584
> -        i->first->flush();

I think this was added during Al's flush patch. Not sure if it's necessary. Seems like it should be done elsewhere anyways.
Comment 3 James Robinson 2011-08-22 19:25:42 PDT
That was added to replace the latch that used to be there, but we don't need to explicit flushes here at all (see the ChangeLog).
Comment 4 James Robinson 2011-08-23 12:15:11 PDT
Comment on attachment 104781 [details]
Patch

Glad you like it, John, but I need a WebKit reviewer to r+ or the tools will yell at me.

Ken, mind officially reviewing this?
Comment 5 Kenneth Russell 2011-08-23 13:58:25 PDT
Comment on attachment 104781 [details]
Patch

Looks good as long as it's been tested with various content to ensure that the flushes being removed aren't necessary.
Comment 6 WebKit Review Bot 2011-08-23 16:01:22 PDT
Comment on attachment 104781 [details]
Patch

Clearing flags on attachment: 104781

Committed r93647: <http://trac.webkit.org/changeset/93647>
Comment 7 WebKit Review Bot 2011-08-23 16:01:26 PDT
All reviewed patches have been landed.  Closing bug.