Bug 66743 – [chromium] Remove obsolete child context list from LayerRendererChromium

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[chromium] Remove obsolete child context list from LayerRendererChromium

[James Robinson]

Created attachment 104781 [details]
Patch

[John Bates]

Comment on attachment 104781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104781&action=review

My precious codez!

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:-584
> -        i->first->flush();

I think this was added during Al's flush patch. Not sure if it's necessary. Seems like it should be done elsewhere anyways.

[James Robinson]

That was added to replace the latch that used to be there, but we don't need to explicit flushes here at all (see the ChangeLog).

[James Robinson]

Comment on attachment 104781 [details]
Patch

Glad you like it, John, but I need a WebKit reviewer to r+ or the tools will yell at me.

Ken, mind officially reviewing this?

[Kenneth Russell]

Comment on attachment 104781 [details]
Patch

Looks good as long as it's been tested with various content to ensure that the flushes being removed aren't necessary.

[WebKit Review Bot]

Comment on attachment 104781 [details]
Patch

Clearing flags on attachment: 104781

Committed r93647: <http://trac.webkit.org/changeset/93647>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.