Bug 63526 - [Meta] Fix unused parameter warnings
Summary: [Meta] Fix unused parameter warnings
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 96712 98243
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-28 03:36 PDT by Csaba Osztrogonác
Modified: 2014-12-03 07:48 PST (History)
4 users (show)

See Also:

Attachments
WIP patch to make Qt Linux build happy (74.87 KB, patch)
2011-06-28 05:51 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-06-28 03:36:06 PDT 
The goal is fix all unused parameter warnings.
Comment 1 Csaba Osztrogonác 2011-06-28 05:51:25 PDT 
Created attachment 98903 [details]
WIP patch to make Qt Linux build happy

cq-, because I'd like to land it manually, because it might 
break Qt-Win, Qt-Symbian and Qt-Mac, Qt-minimal platforms.
Comment 2 WebKit Review Bot 2011-06-28 05:54:08 PDT 
Attachment 98903 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/JavaScriptCore/Change..." exit_code: 1

Source/WebCore/platform/RuntimeApplicationChecks.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/qt/QWebPageClient.h:60:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 2 in 68 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2011-06-28 05:56:31 PDT 
Comment on attachment 98903 [details]
WIP patch to make Qt Linux build happy

Attachment 98903 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8950712
Comment 4 Early Warning System Bot 2011-06-28 06:01:36 PDT 
Comment on attachment 98903 [details]
WIP patch to make Qt Linux build happy

Attachment 98903 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8952578
Comment 5 WebKit Review Bot 2011-06-28 06:12:33 PDT 
Comment on attachment 98903 [details]
WIP patch to make Qt Linux build happy

Attachment 98903 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8951598
Comment 6 Csaba Osztrogonác 2011-06-28 06:36:42 PDT 
Comment on attachment 98903 [details]
WIP patch to make Qt Linux build happy

will fix
Comment 7 Csaba Osztrogonác 2014-12-03 07:48:41 PST 
There is no Qt and the patch is obsolete, these warnings are fixed continuosly.