Bug 96712 – Fix unused parameter compile warnings in WebCore.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kangil Han]

There are several unused parameter warnings found during EFL build.

[Kangil Han]

Created attachment 164044 [details]
patch

[WebKit Review Bot]

Attachment 164044 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:93:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:479:  init_source is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:489:  fill_input_buffer is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kangil Han]

Created attachment 164045 [details]
patch

[WebKit Review Bot]

Attachment 164045 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:479:  init_source is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:489:  fill_input_buffer is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kangil Han]

(In reply to comment #4)
> Attachment 164045 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:479:  init_source is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:489:  fill_input_buffer is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
> Total errors found: 2 in 45 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

I don't think I could fix these style errors.
It was already there.

[Gyuyoung Kim]

(In reply to comment #5)

> > If any of these errors are false positives, please file a bug against check-webkit-style.
> 
> I don't think I could fix these style errors.
> It was already there.

It looks this style error has existed before.

[Ryosuke Niwa]

Comment on attachment 164045 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164045&action=review

> Source/WebCore/platform/efl/PasteboardEfl.cpp:86
> +                                                          bool, bool&)

Wrong indentation! Also, you can fit bool & bool& on the previous line.

[Ryosuke Niwa]

Comment on attachment 164045 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164045&action=review

> Source/WebCore/platform/efl/PasteboardEfl.cpp:86
> +                                                          bool, bool&)

Wrong indentation! Also, you can fit bool & bool& on the previous line.

[Kangil Han]

Created attachment 164057 [details]
patch

Done, thanks!

[WebKit Review Bot]

Attachment 164057 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:479:  init_source is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:489:  fill_input_buffer is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gyuyoung Kim]

Comment on attachment 164057 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=164057&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Missing reviewer name though this patch is reviewed by rniwa.

[Kangil Han]

(In reply to comment #11)
> (From update of attachment 164057 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164057&action=review
> 
> > Source/WebCore/ChangeLog:6
> > +        Reviewed by NOBODY (OOPS!).
> 
> Missing reviewer name though this patch is reviewed by rniwa.

oops.. i will get back soon..

[Kangil Han]

Created attachment 164060 [details]
patch

Done!

[WebKit Review Bot]

Attachment 164060 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:479:  init_source is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:489:  fill_input_buffer is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gyuyoung Kim]

This patch should pass all ews.

[WebKit Review Bot]

Comment on attachment 164060 [details]
patch

Clearing flags on attachment: 164060

Committed r128570: <http://trac.webkit.org/changeset/128570>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.