Bug 98243 - Fix unused parameter compile warnings.
Summary: Fix unused parameter compile warnings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks: 63526
  Show dependency tree / graph
 
Reported: 2012-10-03 02:03 PDT by Kangil Han
Modified: 2012-10-03 18:50 PDT (History)
3 users (show)

See Also:

Attachments
patch (10.96 KB, patch)
2012-10-03 02:13 PDT, Kangil Han 		ap: review+
Details | Formatted Diff | Diff
patch (11.03 KB, patch)
2012-10-03 17:53 PDT, Kangil Han 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-10-03 02:03:57 PDT 
Fixed unused parameter compile warnings found during WebKit EFL debug build.
Comment 1 Kangil Han 2012-10-03 02:13:51 PDT 
Created attachment 166831 [details]
patch
Comment 2 Gyuyoung Kim 2012-10-03 17:36:19 PDT 
Comment on attachment 166831 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166831&action=review

> Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp:450
> +void PluginProxy::contentsScaleFactorChanged(float /*scaleFactor*/)

I think function name can be enough to represent parameter name. So, this parameter can be removed.
Comment 3 Kangil Han 2012-10-03 17:53:21 PDT 
Created attachment 167009 [details]
patch

Done!
Comment 4 WebKit Review Bot 2012-10-03 18:50:01 PDT 
Comment on attachment 167009 [details]
patch

Clearing flags on attachment: 167009

Committed r130353: <http://trac.webkit.org/changeset/130353>
Comment 5 WebKit Review Bot 2012-10-03 18:50:05 PDT 
All reviewed patches have been landed.  Closing bug.