Bug 63132 - [Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
Summary: [Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.6
: P1 Critical
Assignee: Zeno Albisser
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 63093 79666 79668
  Show dependency tree / graph
 
Reported: 2011-06-22 04:55 PDT by Csaba Osztrogonác
Modified: 2012-05-16 12:47 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2012-05-16 11:05 PDT, Marcelo Lira 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-06-22 04:55:12 PDT 
I don't have a Mac, so I can't test it. I cc-ed Qt Mac responsibles.

Wed Jun 22 07:33:01 .... DumpRenderTree[1302] <Error>: ATSFontGetFileReference failed: error -50.
Segmentation fault
Comment 1 Matthew Delaney 2011-06-22 08:10:47 PDT 
I believe I saw this failing when I ran the layout tests before I made my code change. I'll try to track down the revision when I get in.
Comment 2 Matthew Delaney 2011-06-22 08:14:34 PDT 
Actually, I take that back. There was another fast/css font test that had been failing on my mac. Did you see this failing on the Qt Mac bots? They look green at the moment - did someone check in expected failing results?
Comment 3 Csaba Osztrogonác 2011-06-22 10:35:01 PDT 
Qt Mac bot isn't core builder, you can find it here: http://build.webkit.sed.hu/waterfall - Qt SnowLeopard Intel Release

fast/css/custom-font-xheight.html still crashes on it
Comment 4 Csaba Osztrogonác 2011-06-27 01:39:56 PDT 
It seems QtWebKit can live with this crash, but red buildbot is absolutely useless, so I added this test to the Skipped list: http://trac.webkit.org/changeset/89807
Comment 5 Marcelo Lira 2012-05-16 11:05:51 PDT 
Created attachment 142302 [details]
Patch
Comment 6 Alexis Menard (darktears) 2012-05-16 11:15:22 PDT 
Comment on attachment 142302 [details]
Patch

rs=me please watch the http://build.webkit.sed.hu/builders/Qt%20Lion%20Intel%20Release to make sure it doesn't crash there.
Comment 7 WebKit Review Bot 2012-05-16 12:47:26 PDT 
Comment on attachment 142302 [details]
Patch

Clearing flags on attachment: 142302

Committed r117325: <http://trac.webkit.org/changeset/117325>
Comment 8 WebKit Review Bot 2012-05-16 12:47:32 PDT 
All reviewed patches have been landed.  Closing bug.