RESOLVED FIXED 63093
beginTransparencyLayer leaves context color out of sync, bleeds color into text 
https://bugs.webkit.org/show_bug.cgi?id=63093
Summary beginTransparencyLayer leaves context color out of sync, bleeds color into text
Matthew Delaney
Reported 2011-06-21 13:57:17 PDT
Created attachment 98054 [details] testcase Attaching a simple testcase that shows a border's color bleeding into the surrounding text. The text should be black, but is getting stuck with the border's blue color.
Attachments
testcase (248 bytes, text/html)
2011-06-21 13:57 PDT, Matthew Delaney 		no flags
Details
Patch (22.65 KB, patch)
2011-06-21 14:57 PDT, Matthew Delaney 		no flags
DetailsFormatted DiffDiff
Patch (25.43 KB, patch)
2011-06-21 16:57 PDT, Matthew Delaney 		simon.fraser: review+
simon.fraser: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-01 (1.50 MB, application/zip)
2011-06-21 17:13 PDT, WebKit Review Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matthew Delaney
Comment 1 2011-06-21 14:57:25 PDT
Created attachment 98060 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-06-21 15:01:18 PDT
Comment on attachment 98060 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98060&action=review > Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:901 > CGContextSaveGState(context); save() calls CGContextSaveGState() so you can remove that. > Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:918 > CGContextRestoreGState(context); > m_data->endTransparencyLayer(); > m_data->m_userToDeviceTransformKnownToBeIdentity = false; > + > + restore(); restore() calls restorePlatformState() which calls both CGContextRestoreGState() and does m_data->m_userToDeviceTransformKnownToBeIdentity = false so you can remove those lines. > LayoutTests/compositing/color-matching/color-leakage.html:16 > +<html> > + <head> > + <style> > + div { > + color: black; > + border-top: 1px solid blue; > + border-bottom: 1px solid rgba(0,0,0,0.9); > + } > + </style> > +</head> > +<body> > + <div> > + This should be black > + </div> > +</body> > +</html> This test needs to be changed to make the pixel failure more detectable (larger text, use Ahem etc).
Matthew Delaney
Comment 3 2011-06-21 16:57:10 PDT
Created attachment 98081 [details] Patch
Simon Fraser (smfr)
Comment 4 2011-06-21 16:58:18 PDT
Comment on attachment 98081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98081&action=review > LayoutTests/fast/css/color-leakage.html:23 > + This text and the Ahem text above should be black. Remove this text. Put in an HTML comment about the Ahem text being black, to reduce text diffs between platforms.
WebKit Review Bot
Comment 5 2011-06-21 17:13:48 PDT
Comment on attachment 98081 [details] Patch Attachment 98081 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8921152 New failing tests: fast/css/color-leakage.html
WebKit Review Bot
Comment 6 2011-06-21 17:13:53 PDT
Created attachment 98083 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Matthew Delaney
Comment 7 2011-06-21 17:40:59 PDT
Committed r89397: <http://trac.webkit.org/changeset/89397>
Alexey Proskuryakov
Comment 8 2011-08-24 11:28:48 PDT
*** Bug 66793 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.