Bug 60546 - [GTK] Implement Plugin Process
Summary: [GTK] Implement Plugin Process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 58223 60293 60539 60629 62124 62200
Blocks: 63248
  Show dependency treegraph
 
Reported: 2011-05-10 06:05 PDT by Carlos Garcia Campos
Modified: 2011-07-14 10:50 PDT (History)
1 user (show)

See Also:


Attachments
Patch (19.30 KB, patch)
2011-06-07 06:25 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch (19.67 KB, patch)
2011-06-20 05:08 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-05-10 06:05:40 PDT
GTK port doesn't support plugin process yet. The main advantage of using another process for plugins for the GTK port is that we can use the flash plugin (that uses gtk2) even if webkit is built with gtk3.
Comment 1 Carlos Garcia Campos 2011-06-07 06:25:27 PDT
Created attachment 96235 [details]
Patch
Comment 2 WebKit Review Bot 2011-06-07 06:28:36 PDT
Attachment 96235 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebKit2/ChangeLog', u..." exit_code: 1

Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:72:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2011-06-20 05:08:04 PDT
Created attachment 97780 [details]
Updated patch

Patch updated to apply on current git master, also simplified te build system a bit since webkit2 doesn't support gtk2 anymore.
Comment 4 WebKit Review Bot 2011-06-20 05:11:40 PDT
Attachment 97780 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebKit2/ChangeLog', u..." exit_code: 1

Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:72:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Martin Robinson 2011-06-20 09:39:19 PDT
Comment on attachment 97780 [details]
Updated patch

Okay! Let's do this.
Comment 6 Carlos Garcia Campos 2011-06-20 11:06:24 PDT
This still depends on bug #60629, so I'll land this as soon as it's fixed. Thanks for reviewing.
Comment 7 Carlos Garcia Campos 2011-07-14 10:50:06 PDT
Committed r91015: <http://trac.webkit.org/changeset/91015>