Bug 60629 – Implement plugin process for UNIX platform

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

Patch attached to bug #57617 contains some parts needed to implement the plugin process that are common to unix platforms.

[Carlos Garcia Campos]

Created attachment 93120 [details]
Patch

This patch contains the common parts needed to implement the plugin process for unix. It's mostly the same patch written by Balazs Kelemen in bug #57617.

[Carlos Garcia Campos]

Created attachment 93415 [details]
Updated patch

Remove assertions that check that the Handle is not null. In PluginProxy::geometryDidChange we pass a null Handle if we do not need to allocate a new backing store.

[Balazs Kelemen]

(In reply to comment #2)
> Created an attachment (id=93415) [details]
> Updated patch
> 
> Remove assertions that check that the Handle is not null. In PluginProxy::geometryDidChange we pass a null Handle if we do not need to allocate a new backing store.

It's in conflict with your comment there: https://bugs.webkit.org/show_bug.cgi?id=57617#c19. Is the patch obsolete now?

[Carlos Garcia Campos]

(In reply to comment #3)
> (In reply to comment #2)
> > Created an attachment (id=93415) [details] [details]
> > Updated patch
> > 
> > Remove assertions that check that the Handle is not null. In PluginProxy::geometryDidChange we pass a null Handle if we do not need to allocate a new backing store.
> 
> It's in conflict with your comment there: https://bugs.webkit.org/show_bug.cgi?id=57617#c19. Is the patch obsolete now?

Yes, see bug https://bugs.webkit.org/show_bug.cgi?id=60621

[Carlos Garcia Campos]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Created an attachment (id=93415) [details] [details] [details]
> > > Updated patch
> > > 
> > > Remove assertions that check that the Handle is not null. In PluginProxy::geometryDidChange we pass a null Handle if we do not need to allocate a new backing store.
> > 
> > It's in conflict with your comment there: https://bugs.webkit.org/show_bug.cgi?id=57617#c19. Is the patch obsolete now?
> 
> Yes, see bug https://bugs.webkit.org/show_bug.cgi?id=60621

Just to clarify, I didn't answer your question, sorry, the changelog text is in conflict with my comment, but the patch is not obsolete, patch attached to bug #60621 allows to send null handles.

[Carlos Garcia Campos]

Created attachment 96081 [details]
Updated patch

Since r88147 the GTK port uses STREAM sockets, so I've updated the patch to use STREAM sockets in the plugin process too for the GTK port.

[Gyuyoung Kim]

Comment on attachment 96081 [details]
Updated patch

Attachment 96081 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/8766865

[Anders Carlsson]

Comment on attachment 96081 [details]
Updated patch

Ideally I'd like to see a generic, cross-platform way to send a connection endpoint over another connection. However, this is fine for now!

[Carlos Garcia Campos]

Committed r91013: <http://trac.webkit.org/changeset/91013>

[Balazs Kelemen]

*** Bug 57617 has been marked as a duplicate of this bug. ***