Bug 63248 – [GTK] Install a custom X error handler in plugin process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

Some plugins, specially flash, can cause X errors that when handled by the default X error handler (or the GDK one) abort the process. See also bug #53016.

[Carlos Garcia Campos]

Created attachment 98336 [details]
Patch

Fixes a crash in plugin process when loading http://www.f1.com

[Martin Robinson]

Comment on attachment 98336 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98336&action=review

> Source/WebKit2/PluginProcess/gtk/PluginProcessMainGtk.cpp:41
> +    gchar errorMessage[64];
> +    XGetErrorText(xdisplay, error->error_code, errorMessage, 63);

Is 64 enough here?

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 98336 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98336&action=review
> 
> > Source/WebKit2/PluginProcess/gtk/PluginProcessMainGtk.cpp:41
> > +    gchar errorMessage[64];
> > +    XGetErrorText(xdisplay, error->error_code, errorMessage, 63);
> 
> Is 64 enough here?

it's based on GDK code, see:

http://git.gnome.org/browse/gtk+/tree/gdk/x11/gdkdisplay-x11.c#n2351

so I guess it's enough, we could use something like 1024 to make sure.

[Carlos Garcia Campos]

Committed r91062: <http://trac.webkit.org/changeset/91062>