cr-linux-ews should run tests
Created attachment 90840 [details] hacks
Comment on attachment 90840 [details] hacks View in context: https://bugs.webkit.org/attachment.cgi?id=90840&action=review > Tools/Scripts/webkitpy/common/config/ports.py:276 > + return None They don't pass?
Created attachment 90862 [details] iterating
Created attachment 91960 [details] Patch
Attachment 91960 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py:114: expected 2 blank lines, found 1 [pep8/E302] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 91960 [details] Patch I think it's wrong to work around "14 failing tests" on the bot by upping the failure limit for the commit-queue as well. :( Better would be to have a test_expectations file for this port, no? Otherwise this looks fine.
Comment on attachment 91960 [details] Patch Clearing flags on attachment: 91960 Committed r85524: <http://trac.webkit.org/changeset/85524>
All reviewed patches have been landed. Closing bug.
I'm running this on one bot currently. If that goes well, I'll expand to the rest.