Bug 59923 - EWS should report the list of unexpected failures
Summary: EWS should report the list of unexpected failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 59272
  Show dependency treegraph
 
Reported: 2011-05-02 02:50 PDT by Adam Barth
Modified: 2011-05-02 13:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.58 KB, patch)
2011-05-02 02:53 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-05-02 02:50:52 PDT
EWS should report the list of unexpected failures
Comment 1 Adam Barth 2011-05-02 02:53:50 PDT
Created attachment 91902 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-05-02 10:13:38 PDT
Comment on attachment 91902 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91902&action=review

> Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:447
> +        task = self._run_through_task(commit_queue, expected_stderr, ScriptError)
> +        self.assertEqual(task.results_from_patch_test_run(task._patch).failing_tests(), ["foo.html", "bar.html"])

Seems to support the case that this should be moved onto a custom Exception.
Comment 3 Adam Barth 2011-05-02 11:57:18 PDT
(In reply to comment #2)
> (From update of attachment 91902 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91902&action=review
> 
> > Tools/Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:447
> > +        task = self._run_through_task(commit_queue, expected_stderr, ScriptError)
> > +        self.assertEqual(task.results_from_patch_test_run(task._patch).failing_tests(), ["foo.html", "bar.html"])
> 
> Seems to support the case that this should be moved onto a custom Exception.

Actually, if we moved it onto a custom exception, the test would be even harder to write.  :)
Comment 4 WebKit Commit Bot 2011-05-02 13:03:04 PDT
Comment on attachment 91902 [details]
Patch

Clearing flags on attachment: 91902

Committed r85509: <http://trac.webkit.org/changeset/85509>
Comment 5 WebKit Commit Bot 2011-05-02 13:03:09 PDT
All reviewed patches have been landed.  Closing bug.