Bug 59915 - workspace.py fails to import ScriptError
Summary: workspace.py fails to import ScriptError
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 59272
  Show dependency treegraph
 
Reported: 2011-05-01 22:29 PDT by Adam Barth
Modified: 2011-05-02 01:15 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.18 KB, patch)
2011-05-01 22:30 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-05-01 22:29:02 PDT
workspace.py fails to import ScriptError
Comment 1 Adam Barth 2011-05-01 22:30:12 PDT
Created attachment 91883 [details]
Patch
Comment 2 WebKit Review Bot 2011-05-01 22:31:07 PDT
Attachment 91883 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1

Tools/Scripts/webkitpy/common/system/workspace_unittest.py:63:  expected 1 blank line, found 0  [pep8/E301] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2011-05-02 00:17:43 PDT
Comment on attachment 91883 [details]
Patch

Clearing flags on attachment: 91883

Committed r85462: <http://trac.webkit.org/changeset/85462>
Comment 4 WebKit Commit Bot 2011-05-02 00:17:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2011-05-02 01:15:46 PDT
The commit-queue encountered the following flaky tests while processing attachment 91883 [details]:

inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org)
The commit-queue is continuing to process your patch.