The window manages to close before a print dialog appears. It would seem that this working in WK1 is more of an accident - both print() and close() are delayed on a timer, and even though timers are FIFO, there is a lot of inherent raciness here.
<rdar://problem/9150861>
Created attachment 90772 [details] proposed fix
Comment on attachment 90772 [details] proposed fix r=me
Comment on attachment 90772 [details] proposed fix Rejecting attachment 90772 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'build-..." exit_code: 2 Last 500 characters of output: sts/xmlhttprequest ................................................................................................................................................................................ http/tests/xmlhttprequest/web-apps ............... http/tests/xmlhttprequest/workers ........... http/tests/xmlviewer . http/tests/xmlviewer/dumpAsText ............ 730.74s total testing time 23375 test cases (99%) succeeded 4 test cases (<1%) had incorrect layout 13 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/8498629
Created attachment 90845 [details] Archive of layout-test-results from cr-jail-7 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: cr-jail-7 Port: Mac Platform: Mac OS X 10.6.6
Created attachment 90847 [details] with updated test results These are progressions. Previously, resource load error delegate calls were made at a wrong time (after frame loader's didFinishLoading), so DumpRenderTree didn't log them.
Created attachment 90848 [details] and now with ChangeLog
Comment on attachment 90848 [details] and now with ChangeLog Rejecting attachment 90848 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1 Last 500 characters of output: ueue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=90848&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=59241&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 90848 from bug 59241. ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Updating OpenSource Current branch master is up to date. Full output: http://queues.webkit.org/results/8493771
(In reply to comment #6) > Created an attachment (id=90847) [details] > with updated test results > > These are progressions. Previously, resource load error delegate calls were made at a wrong time (after frame loader's didFinishLoading), so DumpRenderTree didn't log them. Your comment made me think of bug 58412. I wonder if the previous issue you mention could be the cause of that flaky test.
Created attachment 90854 [details] commit-queue, it's your last chance > Your comment made me think of bug 58412. I wonder if the previous issue you mention could be the cause of that flaky test. This patch is unlikely to fix it - it only changes the behavior when main resource load is canceled somehow.
Comment on attachment 90854 [details] commit-queue, it's your last chance Clearing flags on attachment: 90854 Committed r84742: <http://trac.webkit.org/changeset/84742>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/84742 might have broken Qt Linux Release The following tests are not passing: http/tests/misc/will-send-request-returns-null-on-redirect.html http/tests/security/XFrameOptions/x-frame-options-deny.html http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
Fixing Qt results seems to require some improvement of DRT result printing - not sure what the strategy is, but it seems that some Mac-specific messages are being already synthesized.
(In reply to comment #14) > Fixing Qt results seems to require some improvement of DRT result printing - not sure what the strategy is, but it seems that some Mac-specific messages are being already synthesized. New bug filed on it: https://bugs.webkit.org/show_bug.cgi?id=59334