Bug 59334 – [Qt] New tests introduced in r84742 fail

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

http/tests/misc/will-send-request-returns-null-on-redirect.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html

http://build.webkit.org/results/Qt%20Linux%20Release/r84743%20%2831878%29/results.html

Comment #14 From Alexey Proskuryakov 2011-04-23 20:21:44 PST (-) [reply]
Fixing Qt results seems to require some improvement of DRT result printing - not sure what the strategy is, but it seems that some Mac-specific messages are being already synthesized.

[Csaba Osztrogonác]

Skipped by http://trac.webkit.org/changeset/84786

[Robert Hogan]

(In reply to comment #0)
> http/tests/security/XFrameOptions/x-frame-options-deny.html
> http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html

These two are benign, we have platform-specific results for the return codes in the same family of tests.

> http/tests/misc/will-send-request-returns-null-on-redirect.html

This one happens because the Qt API considers a load finished (and DRT dumps it results) when postProgressFinishedNotification() is fired from ProgressTracker::finalProgressComplete() for the main frame. By the time dispatchDidFailLoading() has been called for the iframe, the DRT has dumped.

I think other tests cope with this by putting a notifyDone() into the load event handler of any subframes. That is probably the fix here, or just accept Qt's platform specific results.

Alexey, does that sound sensible to you or do you suspect Qt is doing something wrong here?

[Ádám Kallai]

I'm reviewing qt test expectations. What do you think about this test? Should I update it or not? It seems this test result is correct with Wk2. 
Thanks for your help!

 * http/tests/misc/will-send-request-returns-null-on-redirect.html


--- /home/kadam/webkit/WebKit/WebKitBuild/Release/layout-test-results/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt
+++ /home/kadam/webkit/WebKit/WebKitBuild/Release/layout-test-results/http/tests/misc/will-send-request-returns-null-on-redirect-actual.txt
@@ -2,7 +2,6 @@
 <unknown> - didFinishLoading
 http://127.0.0.1:8000/misc/resources/redirect-to-http-url.php - willSendRequest <NSURLRequest URL http://www.example.com/, main document URL http://127.0.0.1:8000/misc/will-send-request-returns-null-on-redirect.html, http method GET> redirectResponse <NSURLResponse http://127.0.0.1:8000/misc/resources/redirect-to-http-url.php, http status code 302>
 Returning null for this redirect
-http://127.0.0.1:8000/misc/resources/redirect-to-http-url.php - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -999>
 https://bugs.webkit.org/show_bug.cgi?id=27595
 This test checks to make sure that things behave as expected when the resource load delegate returns null in response to willSendRequest.