Bug 57779 - [meta] refactoring of RenderBlockLineLayout.cpp
Summary: [meta] refactoring of RenderBlockLineLayout.cpp
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on: 58557 36921 57851 57947 57965 58028 58362 58400 58411 60044 60046 60072 60082 60117 60209
Blocks:
  Show dependency tree / graph
 
Reported: 2011-04-04 13:12 PDT by Ryosuke Niwa
Modified: 2011-05-04 19:47 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-04-04 13:12:52 PDT 
findNextLineBreak is an ancient function and violates almost all WebKit style guides.  We should cleanup this function and split it into smaller pieces.
Comment 1 Levi Weintraub 2011-04-06 02:47:46 PDT 
Changing the name because there's lots of good refactoring to be done in that entire file.
Comment 2 Eric Seidel (no email) 2011-04-06 05:25:32 PDT 
I want to split most of the code in this file off into a new class called LineBoxTree.  Basically RenderBlock should be *much* simpler than it is today, and all of the line-box-tree related code should move into a new LineBoxTree class which it has one of as a m_lineboxTree member.