WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
57779
[meta] refactoring of RenderBlockLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=57779
Summary
[meta] refactoring of RenderBlockLineLayout.cpp
Ryosuke Niwa
Reported
2011-04-04 13:12:52 PDT
findNextLineBreak is an ancient function and violates almost all WebKit style guides. We should cleanup this function and split it into smaller pieces.
Attachments
Add attachment
proposed patch, testcase, etc.
Levi Weintraub
Comment 1
2011-04-06 02:47:46 PDT
Changing the name because there's lots of good refactoring to be done in that entire file.
Eric Seidel (no email)
Comment 2
2011-04-06 05:25:32 PDT
I want to split most of the code in this file off into a new class called LineBoxTree. Basically RenderBlock should be *much* simpler than it is today, and all of the line-box-tree related code should move into a new LineBoxTree class which it has one of as a m_lineboxTree member.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug