Bug 57947 - Split getBorderPaddingMargin into two functions
Summary: Split getBorderPaddingMargin into two functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 57779
  Show dependency treegraph
 
Reported: 2011-04-06 07:34 PDT by Ryosuke Niwa
Modified: 2011-04-06 11:05 PDT (History)
8 users (show)

See Also:


Attachments
cleanup (3.12 KB, patch)
2011-04-06 08:11 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-04-06 07:34:00 PDT
This is a cleanup.
Comment 1 Ryosuke Niwa 2011-04-06 08:11:44 PDT
Created attachment 88425 [details]
cleanup
Comment 2 Ryosuke Niwa 2011-04-06 08:12:52 PDT
Comment on attachment 88425 [details]
cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=88425&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:66
> +    // FIXME: Should we call marginStartForChild instead?
>      return child->marginStart() + child->paddingStart() + child->borderStart();

It's really odd that we don't call marginStartForChild here.  This is almost the only place we call marginStart instead.

Dave & Simon, this is correct?
Comment 3 Dimitri Glazkov (Google) 2011-04-06 08:51:43 PDT
Comment on attachment 88425 [details]
cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=88425&action=review

ok.

> Source/WebCore/ChangeLog:7
> +

Usually I put in something explaining why there aren't tests. Like:

Refactoring, covered by existing tests.

Or

Refactoring, no functional change.
Comment 4 WebKit Commit Bot 2011-04-06 10:06:30 PDT
Comment on attachment 88425 [details]
cleanup

Clearing flags on attachment: 88425

Committed r83066: <http://trac.webkit.org/changeset/83066>
Comment 5 WebKit Commit Bot 2011-04-06 10:06:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2011-04-06 11:05:51 PDT
http://trac.webkit.org/changeset/83066 might have broken GTK Linux 32-bit Release
The following tests are not passing:
fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
fast/dom/HTMLProgressElement/progress-element.html