Split getBorderPaddingMargin into two functions

[Ryosuke Niwa]

This is a cleanup.

[Ryosuke Niwa]

Created attachment 88425 [details]
cleanup

[Ryosuke Niwa]

Comment on attachment 88425 [details]
cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=88425&action=review

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:66
> +    // FIXME: Should we call marginStartForChild instead?
>      return child->marginStart() + child->paddingStart() + child->borderStart();

It's really odd that we don't call marginStartForChild here.  This is almost the only place we call marginStart instead.

Dave & Simon, this is correct?

[Dimitri Glazkov (Google)]

Comment on attachment 88425 [details]
cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=88425&action=review

ok.

> Source/WebCore/ChangeLog:7
> +

Usually I put in something explaining why there aren't tests. Like:

Refactoring, covered by existing tests.

Or

Refactoring, no functional change.

[WebKit Commit Bot]

Comment on attachment 88425 [details]
cleanup

Clearing flags on attachment: 88425

Committed r83066: <http://trac.webkit.org/changeset/83066>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/83066 might have broken GTK Linux 32-bit Release
The following tests are not passing:
fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
fast/dom/HTMLProgressElement/progress-element.html