Bug 58411 - Merge LineOffsets and LineWidth
Summary: Merge LineOffsets and LineWidth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 57779
  Show dependency treegraph
 
Reported: 2011-04-12 19:32 PDT by Ryosuke Niwa
Modified: 2011-04-13 17:59 PDT (History)
6 users (show)

See Also:


Attachments
cleanup (15.60 KB, patch)
2011-04-12 20:00 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-04-12 19:32:00 PDT
We should merge LineOffsets and LineWidth classes in RenderBlockLineLayout.cpp
Comment 1 Ryosuke Niwa 2011-04-12 20:00:10 PDT
Created attachment 89329 [details]
cleanup
Comment 2 Ryosuke Niwa 2011-04-13 11:32:11 PDT
ping?
Comment 3 Eric Seidel (no email) 2011-04-13 11:42:01 PDT
I'm not sure I fully understand the motivation of this change.  I can't tell if the code is better with it or not.
Comment 4 Ryosuke Niwa 2011-04-13 11:56:06 PDT
(In reply to comment #3)
> I'm not sure I fully understand the motivation of this change.  I can't tell if the code is better with it or not.

LineOffsets is used only to compute m_availableWidth, which is a member variable of LineWidth.  Combining these two classes allow us to encapsulate mutations of m_availableWidth entirely, and hide left/right mechanism we use internally to figure out the correct available width.
Comment 5 Eric Seidel (no email) 2011-04-13 11:58:13 PDT
Comment on attachment 89329 [details]
cleanup

OK.
Comment 6 WebKit Commit Bot 2011-04-13 17:58:57 PDT
Comment on attachment 89329 [details]
cleanup

Clearing flags on attachment: 89329

Committed r83794: <http://trac.webkit.org/changeset/83794>
Comment 7 WebKit Commit Bot 2011-04-13 17:59:03 PDT
All reviewed patches have been landed.  Closing bug.