WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
58411
Merge LineOffsets and LineWidth
https://bugs.webkit.org/show_bug.cgi?id=58411
Summary
Merge LineOffsets and LineWidth
Ryosuke Niwa
Reported
2011-04-12 19:32:00 PDT
We should merge LineOffsets and LineWidth classes in RenderBlockLineLayout.cpp
Attachments
cleanup
(15.60 KB, patch)
2011-04-12 20:00 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2011-04-12 20:00:10 PDT
Created
attachment 89329
[details]
cleanup
Ryosuke Niwa
Comment 2
2011-04-13 11:32:11 PDT
ping?
Eric Seidel (no email)
Comment 3
2011-04-13 11:42:01 PDT
I'm not sure I fully understand the motivation of this change. I can't tell if the code is better with it or not.
Ryosuke Niwa
Comment 4
2011-04-13 11:56:06 PDT
(In reply to
comment #3
)
> I'm not sure I fully understand the motivation of this change. I can't tell if the code is better with it or not.
LineOffsets is used only to compute m_availableWidth, which is a member variable of LineWidth. Combining these two classes allow us to encapsulate mutations of m_availableWidth entirely, and hide left/right mechanism we use internally to figure out the correct available width.
Eric Seidel (no email)
Comment 5
2011-04-13 11:58:13 PDT
Comment on
attachment 89329
[details]
cleanup OK.
WebKit Commit Bot
Comment 6
2011-04-13 17:58:57 PDT
Comment on
attachment 89329
[details]
cleanup Clearing flags on attachment: 89329 Committed
r83794
: <
http://trac.webkit.org/changeset/83794
>
WebKit Commit Bot
Comment 7
2011-04-13 17:59:03 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug