Bug 57021 - [Qt] MiniBrowser defaultUrl does not work
Summary: [Qt] MiniBrowser defaultUrl does not work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-24 08:49 PDT by Chang Shu
Modified: 2011-04-05 09:54 PDT (History)
3 users (show)

See Also:

Attachments
fix patch (1.38 KB, patch)
2011-04-04 08:12 PDT, Chang Shu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-03-24 08:49:36 PDT 
This feature was fixed in QtTestBrowser but MiniBrowser is still using the broken code.
https://bugs.webkit.org/show_bug.cgi?id=46465
Comment 1 Chang Shu 2011-04-04 08:12:21 PDT 
Created attachment 88063 [details]
fix patch

Keith, I don't see you are working on it. So I made a patch myself.
Comment 2 Laszlo Gombos 2011-04-05 06:01:50 PDT 
Comment on attachment 88063 [details]
fix patch

r=me. Thanks.
Comment 3 WebKit Commit Bot 2011-04-05 07:48:32 PDT 
Comment on attachment 88063 [details]
fix patch

Clearing flags on attachment: 88063

Committed r82938: <http://trac.webkit.org/changeset/82938>
Comment 4 WebKit Commit Bot 2011-04-05 07:48:36 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2011-04-05 09:54:45 PDT 
The commit-queue encountered the following flaky tests while processing attachment 88063 [details]:

http/tests/media/video-load-twice.html bug 51138 (authors: eric.carlson@apple.com and jamesr@chromium.org)
The commit-queue is continuing to process your patch.