Bug 46465 - [Qt] QtTestBrowser defaultUrl does not work
Summary: [Qt] QtTestBrowser defaultUrl does not work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P4 Normal
Assignee: Chang Shu
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-09-24 07:23 PDT by Chang Shu
Modified: 2010-09-24 10:08 PDT (History)
3 users (show)

See Also:


Attachments
fix patch (1.30 KB, patch)
2010-09-24 07:41 PDT, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2010-09-24 07:23:42 PDT
QtTestBrowser is capable of loading a local index.html by default. However, it is broken now.
Comment 1 Chang Shu 2010-09-24 07:41:57 PDT
Created attachment 68678 [details]
fix patch
Comment 2 Csaba Osztrogonác 2010-09-24 08:51:41 PDT
Comment on attachment 68678 [details]
fix patch

LGTM, r=me
Comment 3 Chang Shu 2010-09-24 08:53:32 PDT
(In reply to comment #2)
> (From update of attachment 68678 [details])
> LGTM, r=me

thanks for the quick review!
Comment 4 Andreas Kling 2010-09-24 09:02:31 PDT
> [Qt] Fix the code to check file existence.

In the future, please write more detailed ChangeLogs.

Example:

> [Qt] Fix loading of the default URL (~/index.html) in QtTestBrowser
> 
> We were erroneously checking for the presence of a *directory* called index.html in the user's
> home directory. Correct this by using QFile::exists() instead of QDir::exists().
Comment 5 WebKit Commit Bot 2010-09-24 09:10:53 PDT
Comment on attachment 68678 [details]
fix patch

Clearing flags on attachment: 68678

Committed r68259: <http://trac.webkit.org/changeset/68259>
Comment 6 WebKit Commit Bot 2010-09-24 09:10:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Antonio Gomes 2010-09-24 09:13:27 PDT
Hum I think this is kinda useless :-( Is anyone leaving an index.html file in the home root dir for testing?
Comment 8 Csaba Osztrogonác 2010-09-24 09:21:48 PDT
(In reply to comment #4)
> > [Qt] Fix the code to check file existence.
> 
> In the future, please write more detailed ChangeLogs.
> 
> Example:
> 
> > [Qt] Fix loading of the default URL (~/index.html) in QtTestBrowser
> > 
> > We were erroneously checking for the presence of a *directory* called index.html in the user's
> > home directory. Correct this by using QFile::exists() instead of QDir::exists().

It is a very simple fix, it's trivial to understand what was wrong.
I don't think if we needed so detailed changelog what you mentioned.
But I agree detailed comments are always welcome.



(In reply to comment #7)
> Hum I think this is kinda useless :-( Is anyone leaving an index.html file in the home root dir for testing?
Not at all. Previously I used this feature. :)
It is good for lazy peoples. :)
Comment 9 Chang Shu 2010-09-24 10:08:29 PDT
> (In reply to comment #7)
> > Hum I think this is kinda useless :-( Is anyone leaving an index.html file in the home root dir for testing?
> Not at all. Previously I used this feature. :)
> It is good for lazy peoples. :)
Right. :) The test browser does not have bookmarks. And typing in the url eidtor is kind of painful, especially on the phone.