Bug 56587 – Implement Layout Tests for the Media Stream API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Leandro Graciá Gil]

Implement the needed code in the LayoutTestController and provide a StreamClientMock to enable layout testing for the Media Stream API.

[Leandro Graciá Gil]

Updating the bug platform settings (had the default ones).

[Tommy Widenflycht]

Created attachment 127175 [details]
Patch

[Tommy Widenflycht]

I have uploaded a complete implementation for discussion purposes only.

[Adam Barth]

Comment on attachment 127175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127175&action=review

The overall structure of this patch looks great.

> Source/WebCore/mediastream/UserMediaClientMock.cpp:47
> +    : m_allowAudio(false), m_allowVideo(false)

These should be on separate lines.

> Source/WebCore/mediastream/UserMediaClientMock.cpp:71
> +        String id("mock_audio_device");
> +        String name("AudioCapture");

We usually just use the assignment form of the constructor.

> Source/WebCore/platform/mediastream/PeerConnectionHandlerMock.cpp:50
> +PeerConnectionHandlerMock::PeerConnectionHandlerMock(PeerConnectionHandlerClient* client, const String& serverConfiguration, PassRefPtr<SecurityOrigin> securityOrigin)

You'll probably need ASSERT_UNUSED for serverConfiguration and securityOrigin to avoid breaking the compile for some ports that don't like unused parameters.  (There are a bunch more examples of this comment in this file.)

[Adam Barth]

Maybe @fishd would like to take a look at the uber patch?

There's a bunch of machinery in the patch that's not needed for the getusermedia-not-allowed.html test.  Maybe a good starting point would be to break off whatever chunk is needed for getusermedia-not-allowed.html into a first patch,.

[Tommy Widenflycht]

(In reply to comment #4)
> (From update of attachment 127175 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127175&action=review
> 
> The overall structure of this patch looks great.
> 
> > Source/WebCore/mediastream/UserMediaClientMock.cpp:47
> > +    : m_allowAudio(false), m_allowVideo(false)
> 
> These should be on separate lines.
> 
> > Source/WebCore/mediastream/UserMediaClientMock.cpp:71
> > +        String id("mock_audio_device");
> > +        String name("AudioCapture");
> 
> We usually just use the assignment form of the constructor.

Thanks for having a first look!

I fixed your comments and uploaded just the UserMediaClientMock related code to 
https://bugs.webkit.org/show_bug.cgi?id=61068

[Tommy Widenflycht]

We now have reasonable layout tests and therefore doesn't need this tracking bug anymore.