Bug 85883 - MediaStream API: Adding a test for constructed from JS MediaStreams
Summary: MediaStream API: Adding a test for constructed from JS MediaStreams
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56587
  Show dependency treegraph
 
Reported: 2012-05-08 07:04 PDT by Tommy Widenflycht
Modified: 2012-05-09 03:48 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.63 KB, patch)
2012-05-08 07:10 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff
Patch (8.57 KB, patch)
2012-05-09 02:37 PDT, Tommy Widenflycht
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-05-08 07:04:47 PDT
MediaStreams can now be created from JS but lacked tests. Fixed.
Comment 1 Tommy Widenflycht 2012-05-08 07:10:48 PDT
Created attachment 140714 [details]
Patch
Comment 2 Kent Tamura 2012-05-09 02:16:31 PDT
Comment on attachment 140714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140714&action=review

> LayoutTests/fast/mediastream/MediaStreamConstructor.html:14
> +function shouldNotThrow(expression)
> +{

* This should be in js-test-pre.js.

* The position of { is inconsistent with other functions.

> LayoutTests/fast/mediastream/MediaStreamConstructor.html:21
> +  try {
> +    eval(expression);
> +    testPassed(expression + " did not throw exception.");
> +  } catch(e) {
> +    testFailed(expression + " should not throw exception. Threw exception " + e);
> +  }
> +}

We usually use four-space indentation in JavaScript code.
We usually put ' ' after 'catch'.
Comment 3 Tommy Widenflycht 2012-05-09 02:37:10 PDT
Created attachment 140894 [details]
Patch
Comment 4 Tommy Widenflycht 2012-05-09 02:37:50 PDT
Comment on attachment 140714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=140714&action=review

>> LayoutTests/fast/mediastream/MediaStreamConstructor.html:14
>> +{
> 
> * This should be in js-test-pre.js.
> 
> * The position of { is inconsistent with other functions.

Fixed.

>> LayoutTests/fast/mediastream/MediaStreamConstructor.html:21
>> +}
> 
> We usually use four-space indentation in JavaScript code.
> We usually put ' ' after 'catch'.

Fixed.
Comment 5 Kent Tamura 2012-05-09 03:11:24 PDT
Comment on attachment 140894 [details]
Patch

Looks ok
Comment 6 WebKit Review Bot 2012-05-09 03:48:29 PDT
Comment on attachment 140894 [details]
Patch

Clearing flags on attachment: 140894

Committed r116511: <http://trac.webkit.org/changeset/116511>
Comment 7 WebKit Review Bot 2012-05-09 03:48:42 PDT
All reviewed patches have been landed.  Closing bug.