Bug 79114 - MediaStream API: Adding a mock for PeerConnectionHandler
Summary: MediaStream API: Adding a mock for PeerConnectionHandler
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks: 56459 56587
  Show dependency tree / graph
 
Reported: 2012-02-21 08:36 PST by Tommy Widenflycht
Modified: 2012-05-04 05:40 PDT (History)
3 users (show)

See Also:

Attachments
Patch (35.44 KB, patch)
2012-02-21 08:46 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (35.43 KB, patch)
2012-02-23 03:34 PST, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-02-21 08:36:44 PST 
Adding a mock for PeerConnectionHandler together with the chromium embedders. No actual LayoutTests since the plumbing needs to be done in chromium first.
Comment 1 Tommy Widenflycht 2012-02-21 08:46:28 PST 
Created attachment 127980 [details]
Patch
Comment 2 Adam Barth 2012-02-22 18:01:26 PST 
Comment on attachment 127980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127980&action=review

> Source/WebCore/mediastream/PeerConnection.h:56
> +    // Name and values of the enum must match the corressponding constants in the PeerConnection.idl file.

Presumably the compiler enforces this with a COMPILE_ASSERT.

> Source/WebKit/chromium/src/WebPeerConnectionHandlerMock.cpp:56
> +WebPeerConnectionHandlerMock:: ~WebPeerConnectionHandlerMock()

Extra space after the ::
Comment 3 Tommy Widenflycht 2012-02-23 03:33:02 PST 
Comment on attachment 127980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=127980&action=review

>> Source/WebCore/mediastream/PeerConnection.h:56
>> +    // Name and values of the enum must match the corressponding constants in the PeerConnection.idl file.
> 
> Presumably the compiler enforces this with a COMPILE_ASSERT.

You're right so I removed the comment.

>> Source/WebKit/chromium/src/WebPeerConnectionHandlerMock.cpp:56
>> +WebPeerConnectionHandlerMock:: ~WebPeerConnectionHandlerMock()
> 
> Extra space after the ::

Fixed.
Comment 4 Tommy Widenflycht 2012-02-23 03:34:25 PST 
Created attachment 128450 [details]
Patch
Comment 5 WebKit Commit Bot 2012-02-24 01:44:17 PST 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 6 Darin Fisher (:fishd, Google) 2012-02-24 10:59:30 PST 
Comment on attachment 128450 [details]
Patch

Why are mocks part of WebCore / WebKit and not just part of DumpRenderTree?