Bug 55474 - Table outlines are not drawn
Summary: Table outlines are not drawn
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
: 41030 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-01 09:18 PST by Abhishek Arya
Modified: 2011-03-30 10:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (31.18 KB, patch)
2011-03-01 09:39 PST, Abhishek Arya 		hyatt: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Abhishek Arya 2011-03-01 09:18:01 PST 
Currently we are not painting outlines for tables.
Comment 1 Abhishek Arya 2011-03-01 09:39:01 PST 
Created attachment 84241 [details]
Patch
Comment 2 Abhishek Arya 2011-03-01 09:41:42 PST 
note that table row outlines does not look supported in IE, opera and firefox draws it incorrectly (try adding a outline to tr in layouttest and try in firefox, you will see incorrect table row and table cell outline overlap). in our code, we do look to paint cell directly without calling rendertablerow paint. So, leaving my patch for checking table outlines and table cell outlines only.
Comment 3 Dave Hyatt 2011-03-01 13:56:17 PST 
Comment on attachment 84241 [details]
Patch

r=me
Comment 4 Abhishek Arya 2011-03-01 14:18:58 PST 
Committed r80040: <http://trac.webkit.org/changeset/80040>
Comment 5 Daniel Bates 2011-03-29 09:43:17 PDT 
*** Bug 41030 has been marked as a duplicate of this bug. ***
Comment 6 Alexey Proskuryakov 2011-03-30 09:58:57 PDT 
See also: bug 35813, bug 18179.
Comment 7 Abhishek Arya 2011-03-30 10:12:57 PDT 
Yeah this 2 liner outline fix has to be added to a couple of Render* classes. I discovered this while fixing one of the security bugs. Also, rendering outline for table rows and columns is tricky because of the overlap problem in certain scenarios. bug 57439 on iframe should be easy enough (try adding these 2 lines to RenderWidget::paint(PaintInfo& paintInfo, int tx, int ty))