Simplify RenderTheme::volumeSliderOffsetFromMuteButton, unduplicate code.

[Dimitri Glazkov (Google)]

Simplify RenderTheme::volumeSliderOffsetFromMuteButton, unduplicate code.

[Dimitri Glazkov (Google)]

Created attachment 83674 [details]
Patch

[Dimitri Glazkov (Google)]

I'll give the bots to cook this patch once bug 55152 patch lands.

[Dimitri Glazkov (Google)]

Comment on attachment 83674 [details]
Patch

Cook, bots, cook!

[Eric Carlson]

Comment on attachment 83674 [details]
Patch

I like the code simplification here, but I don't so much like RenderTheme::volumeSliderOffsetFromMuteButton changing to RenderTheme:: volumeSliderOffset because the new name says nothing about what the offset is relative to. Please consider a more descriptive name: volumeSliderOffsetRelativeToMuteButton, volumeSliderOffsetFromMuteButton, ...

[Dimitri Glazkov (Google)]

Created attachment 83696 [details]
Uses volumeSliderOffsetRelativeToMuteButton.

[Dimitri Glazkov (Google)]

Committed r79607: <http://trac.webkit.org/changeset/79607>

[Dimitri Glazkov (Google)]

Reverted r79607 for reason:

Broke Chromium layout tests.

Committed r79613: <http://trac.webkit.org/changeset/79613>

[Dimitri Glazkov (Google)]

(In reply to comment #7)
> Reverted r79607 for reason:
> 
> Broke Chromium layout tests.
> 
> Committed r79613: <http://trac.webkit.org/changeset/79613>

I messed up. The logic for calculating offsets wasn't the same. Need to think on this a bit more.

[WebKit Review Bot]

http://trac.webkit.org/changeset/79613 might have broken Qt Linux Release

[Dimitri Glazkov (Google)]

Went with a milder version of this refactoring instead. See bug 55099.