Bug 55152 - Add RenderMediaControls to Mac build, unduplicate one method.
Summary: Add RenderMediaControls to Mac build, unduplicate one method.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 53020 55157
  Show dependency tree / graph
 
Reported: 2011-02-24 09:04 PST by Dimitri Glazkov (Google)
Modified: 2011-02-24 23:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (11.39 KB, patch)
2011-02-24 09:07 PST, Dimitri Glazkov (Google) 		eric.carlson: review+
dglazkov: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-02-24 09:04:51 PST 
Add RenderMediaControls to Mac build, unduplicate one method.
Comment 1 Dimitri Glazkov (Google) 2011-02-24 09:07:17 PST 
Created attachment 83666 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-02-24 10:54:27 PST 
Committed r79591: <http://trac.webkit.org/changeset/79591>
Comment 3 WebKit Review Bot 2011-02-24 15:59:11 PST 
http://trac.webkit.org/changeset/79591 might have broken GTK Linux 32-bit Release
Comment 4 Alexey Proskuryakov 2011-02-24 23:01:07 PST 
+// FIXME: Is this necessary anymore?
 #define wkMediaControllerThemeAvailable(themeStyle) WKMediaControllerThemeAvailable(themeStyle)

Unfortunately, yes - this is necessary because there is a mistake (incorrect capitalization) in WKSI on Windows, which we should fix on some lazy afternoon.