Bug 55099 - Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
Summary: Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actua...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 53020
  Show dependency treegraph
 
Reported: 2011-02-23 16:21 PST by Dimitri Glazkov (Google)
Modified: 2011-03-03 13:30 PST (History)
5 users (show)

See Also:


Attachments
Patch (9.91 KB, patch)
2011-02-23 16:23 PST, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Patch (10.84 KB, patch)
2011-03-03 13:11 PST, Dimitri Glazkov (Google)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-02-23 16:21:03 PST
Use RenderBox in volumeSliderOffsetFromMuteButton, since that's what is actually being used.
Comment 1 Dimitri Glazkov (Google) 2011-02-23 16:23:40 PST
Created attachment 83573 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-02-23 16:35:39 PST
Comment on attachment 83573 [details]
Patch

Actually, I think I can replace this whole mess with a better, cleaner mess.
Comment 3 Dimitri Glazkov (Google) 2011-03-03 11:46:39 PST
Turns out better mess didn't work out. Patch coming up.
Comment 4 Dimitri Glazkov (Google) 2011-03-03 13:11:05 PST
Created attachment 84615 [details]
Patch
Comment 5 Dimitri Glazkov (Google) 2011-03-03 13:19:35 PST
Committed r80276: <http://trac.webkit.org/changeset/80276>
Comment 6 WebKit Review Bot 2011-03-03 13:30:16 PST
http://trac.webkit.org/changeset/80276 might have broken Windows Release (Build) and Windows Debug (Build)