Bug 50921 – [Chromium] Remove non-client-based Geolocation code

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[John Knottenbelt]

Once the client-based Geolocation implementation is being tested by DumpRenderTree and passing, we can remove the old non-client-based code in Chromium's WebKit port.

[John Knottenbelt]

Created attachment 78105 [details]
Patch

[Steve Block]

Comment on attachment 78105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78105&action=review

LGTM, but would be good to get sign-off from a Chromium person to confirm that this is the right approach.

> WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Can't submit with an OOPS. Just say that it's code cleanup and is tested with existing tests.

[John Knottenbelt]

Created attachment 78123 [details]
Patch

[Jeremy Orlow]

Comment on attachment 78123 [details]
Patch

r=me

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 78123 [details]:

media/invalid-media-url-crash.html bug 51138 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 78123 [details]
Patch

Rejecting attachment 78123 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 78123]" exit_code: 1
Last 500 characters of output:
//bugs.webkit.org/attachment.cgi?id=78123&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=50921&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 78123 from bug 50921.
The diff to Tools/ChangeLog looks wrong.  Are you sure your ChangeLog entry is at the top of the file?
ERROR: ChangeLog entry in Tools/ChangeLog is not at the top of the file.
Updating OpenSource
Current branch master is up to date.
OK to continue? [y/N]: 
Full output: http://queues.webkit.org/results/7360035

[Eric Seidel (no email)]

Comment on attachment 78123 [details]
Patch

I think the queue is confused.  It hung on this patch due to bug 52072.  But I've fixed that now.  Still the patch looks fine, so I'm not sure how the ChangeLog diff got bad.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 78123 [details]:

http/tests/canvas/webgl/origin-clean-conformance.html bug 52117 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 78123 [details]
Patch

Rejecting attachment 78123 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 78123]" exit_code: 1
Last 500 characters of output:
 directory
Updating working directory
Processing patch 78123 from bug 50921.
ERROR: ChangeLog entry in Tools/ChangeLog is not at the top of the file.
Updating OpenSource
From git://git.webkit.org/WebKit
   abea93c..3947a3a  master     -> origin/master
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/platform/qt/CookieJarQt.cpp
r75334 = 3947a3a011e2afbb5e9e6d02abd9b8f13b192373 (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/7409053

[John Knottenbelt]

Created attachment 78390 [details]
Patch

[Jeremy Orlow]

Comment on attachment 78390 [details]
Patch

rubber stamp

[Jeremy Orlow]

Comment on attachment 78390 [details]
Patch

Clearing flags on attachment: 78390

Committed r75367: <http://trac.webkit.org/changeset/75367>

[Jeremy Orlow]

All reviewed patches have been landed.  Closing bug.