Bug 50562 - Enable client-based geolocation in Chromium
Summary: Enable client-based geolocation in Chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 45752 50920
Blocks: 50921
  Show dependency tree / graph
 
Reported: 2010-12-06 04:49 PST by John Knottenbelt
Modified: 2010-12-16 15:38 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.05 KB, patch)
2010-12-13 09:21 PST, John Knottenbelt 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Knottenbelt 2010-12-06 04:49:22 PST 
Set the CLIENT_BASED_GEOLOCATION flag in Chromium.
Enable test fast/dom/Geolocation/delayed-permission-timeout.html
Comment 1 John Knottenbelt 2010-12-13 09:21:27 PST 
Created attachment 76391 [details]
Patch
Comment 2 John Knottenbelt 2010-12-13 09:40:45 PST 
Enable CLIENT_BASED_GEOLOCATION in the WebKit Chromium smoke tests in preparation for enabling client-based geolocation support in Chromium itself.
Comment 3 Jeremy Orlow 2010-12-16 02:09:47 PST 
Comment on attachment 76391 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2010-12-16 05:38:38 PST 
Comment on attachment 76391 [details]
Patch

Rejecting attachment 76391 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 76391]" exit_code: 2
Last 500 characters of output:
ailed to merge in the changes.
Patch failed at 0001 2010-12-16  Yury Semikhatsky  <yurys@chromium.org>

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at WebKitTools/Scripts/update-webkit line 132.

Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2

Full output: http://queues.webkit.org/results/7080055
Comment 5 Jeremy Orlow 2010-12-16 07:05:45 PST 
Comment on attachment 76391 [details]
Patch

Clearing flags on attachment: 76391

Committed r74189: <http://trac.webkit.org/changeset/74189>
Comment 6 Jeremy Orlow 2010-12-16 07:05:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Eric Seidel (no email) 2010-12-16 14:35:15 PST 
Sorry.  The git repo on one of the commit-bots got corrupted.  I'm attempting to fix it now.
Comment 8 Eric Seidel (no email) 2010-12-16 14:35:51 PST 
Sorry.  The git repo on one of the commit-queue bots got corrupted. :(
Comment 9 WebKit Review Bot 2010-12-16 15:38:50 PST 
http://trac.webkit.org/changeset/74189 might have broken Leopard Intel Debug (Tests)