Bug 50920 - Fix layout test dom/fast/Geolocation/permission-denied-already-error.html for client-based Geolocation
Summary: Fix layout test dom/fast/Geolocation/permission-denied-already-error.html for...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 50562
  Show dependency treegraph
Reported: 2010-12-13 06:17 PST by John Knottenbelt
Modified: 2010-12-13 09:05 PST (History)
5 users (show)

See Also:

Patch (1.48 KB, patch)
2010-12-13 06:19 PST, John Knottenbelt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Knottenbelt 2010-12-13 06:17:53 PST
Use a valid error code (position unavailable == 2) to avoid an assertion failure in Chromium's client-based mock geolocation client.
Comment 1 John Knottenbelt 2010-12-13 06:19:23 PST
Created attachment 76379 [details]
Comment 2 Steve Block 2010-12-13 06:30:56 PST
Comment on attachment 76379 [details]

Comment 3 WebKit Commit Bot 2010-12-13 07:18:00 PST
The commit-queue encountered the following flaky tests while processing attachment 76379 [details]:

fast/profiler/throw-exception-from-eval.html bug 50923 (authors: kmccullough@apple.com, oliver@apple.com, and timothy@apple.com)
inspector/syntax-highlight-css.html bug 50924 (authors: keishi@webkit.org, pfeldman@chromium.org, and yurys@chromium.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-12-13 07:54:46 PST
Comment on attachment 76379 [details]

Clearing flags on attachment: 76379

Committed r73919: <http://trac.webkit.org/changeset/73919>
Comment 5 WebKit Commit Bot 2010-12-13 07:54:51 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-12-13 09:05:55 PST
http://trac.webkit.org/changeset/73919 might have broken GTK Linux 64-bit Debug