Bug 49127 - [Qt] REGRESSION (r71465): editing/selection/after-line-break.html fails
Summary: [Qt] REGRESSION (r71465): editing/selection/after-line-break.html fails
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged, Regression
Depends on:
Blocks: 47237 79666
  Show dependency tree / graph
 
Reported: 2010-11-06 01:36 PDT by Csaba Osztrogonác
Modified: 2014-02-01 18:59 PST (History)
9 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2010-11-06 01:36:54 PDT 
r71465 make editing/selection/after-line-break.html fail on Qt bot:
http://build.webkit.org/results/Qt%20Linux%20Release/r71467%20%2823280%29/editing/selection/after-line-break-pretty-diff.html
Comment 1 Csaba Osztrogonác 2010-11-08 01:13:20 PST 
Skipped until fix: http://trac.webkit.org/changeset/71504
Comment 2 Robert Hogan 2010-11-23 12:33:26 PST 
It looks like only Mac platforms get the new expected result for this test.

Chromium Win and Linux both get what Qt does:
 https://bugs.webkit.org/show_bug.cgi?id=47237#c10

Gtk skips this test already.

I think our results are good.
Comment 3 Luiz Agostini 2011-05-18 14:13:32 PDT 
As Robert said our results seems to be OK and the bug that should be blocked by this one is now RESOLVED FIXED.

I think that we should keep this bug open as a reminder but we should change its priority. I will do it if no one has objections.
Comment 4 Joel Parks 2011-06-27 12:55:31 PDT 
(In reply to comment #3)
> As Robert said our results seems to be OK and the bug that should be blocked by this one is now RESOLVED FIXED.
> 
> I think that we should keep this bug open as a reminder but we should change its priority. I will do it if no one has objections.

please do
Comment 5 Csaba Osztrogonác 2012-05-17 04:26:20 PDT 
It still fails, here is the diff:

--- /home/oszi/WebKit/WebKitBuild/Release/layout-test-results/editing/selection/after-line-break-expected.txt 
+++ /home/oszi/WebKit/WebKitBuild/Release/layout-test-results/editing/selection/after-line-break-actual.txt 
@@ -1,6 +1,6 @@
 EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of DIV > BODY > HTML > #document to 1 of DIV > BODY > HTML > #document
 EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 5 of #text > DIV > BODY > HTML > #document to 5 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 Test for rdar://problem/5973313 REGRESSION (r32508): Down arrow doesn't change caret with non-user entered newlines in textareas.
Comment 6 Ádám Kallai 2012-10-03 07:23:59 PDT 
Is Anybody working this bug? This test still fails on Qt. The fail is same.
Comment 7 Csaba Osztrogonác 2012-11-21 03:18:12 PST 
still valid bug
Comment 8 Ádám Kallai 2013-02-17 14:34:04 PST 
The bug is still vaild.