WebKit Bugzilla
You need to log in before you can comment on or make changes to this bug.
Currently suspendAnimations/resumeAnimations in WebCore take a document, but the pass through from WebKit, which allows access from LayoutTestController simply passes in the top-level document. The WebKit versions should traverse all subframes. Also, we don't remember the suspend state in AnimationController, so starting a new animation while suspended doesn't suspend. I'm fixing these together because the test case I am writing needs the functionality in the former to test the latter.
Dup of bug 46429?
*** Bug 46944 has been marked as a duplicate of this bug. ***
*** Bug 46429 has been marked as a duplicate of this bug. ***
<rdar://problem/8472265>
Created an attachment (id=72995) [details] Patch
(From update of attachment 72995 [details]) View in context: https://bugs.webkit.org/attachment.cgi?id=72995&action=review > LayoutTests/animations/animation-test-helpers.js:82 > + } > + } inIframe is redundant, because you could just test if (iframeId)... > LayoutTests/animations/stop-animation-on-suspend.html:56 > + setTimeout(suspend, 250); > + setTimeout(resume, 500); Can we make this test faster?
(From update of attachment 72995 [details]) We should not be adding new functions to Frame. We’ve been working hard slowly moving functions off of it and adding new ones is not a good idea. These function should go on the animation controller.
(In reply to comment #7) > (From update of attachment 72995 [details] [details]) > We should not be adding new functions to Frame. We’ve been working hard slowly moving functions off of it and adding new ones is not a good idea. These function should go on the animation controller. Sorry, but I already checked in before seeing this. I have opened a new bug (https://bugs.webkit.org/show_bug.cgi?id=49073) to make this change.
Landed in http://trac.webkit.org/changeset/71424