Bug 46540 – Resuming animations causes webkitAnimationStart events to be fired

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

When animations are resumed on AnimationController, webkitAnimationStarts are fired again.

[Simon Fraser (smfr)]

<rdar://problem/8477476>

[Chris Marrin]

Created attachment 71920 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 71920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71920&action=review

r=me with some test tweaking.

> WebCore/page/animation/KeyframeAnimation.h:93
> +    bool m_startEventSent;

Maybe call this m_startEventDispatched?

> LayoutTests/animations/suspend-resume-animation-events.html:15
> +      -webkit-animation-duration: 1s;
> +      -webkit-animation-timing-function: linear;
> +      -webkit-animation-direction: alternate;
> +      -webkit-animation-iteration-count: 2;

It's a shame to add another animation test that takes significant time (slowing down the bots and everyone running tests). We should strive to make the test as brief as possible.

> LayoutTests/animations/suspend-resume-animation-events.html:64
> +    runAnimationTest(expectedValues, setTimers, undefined, true);

Please add inline comments (or use named variables) to explain what 'undefined' and 'true' mean.

> LayoutTests/animations/suspend-resume-animation-events.html:72
> +This test shows suspend and resume of a box moving to the right 500px and then back to 0px. If running inside 
> +DumpRenderTest the box should stop at 200px after 400ms. After another 600ms the move should resume and then 
> +continue to complete the move in another 1.6s.

This text is superfluous.

[Chris Marrin]

Landed in http://trac.webkit.org/changeset/70553