RESOLVED FIXED 46525
When animations are paused, play-state can cause them to be unpaused. 
https://bugs.webkit.org/show_bug.cgi?id=46525
Summary When animations are paused, play-state can cause them to be unpaused.
Simon Fraser (smfr)
Reported 2010-09-24 15:18:06 PDT
Load LayoutTests/animations/play-state.html, and just after the animation starts, pause animations. Note how the animations automatically resume when play-state changes.
Attachments
Patch (7.02 KB, patch)
2010-11-02 11:00 PDT, Chris Marrin 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-09-24 15:18:37 PDT
<rdar://problem/8476959>
Chris Marrin
Comment 2 2010-11-02 11:00:51 PDT
Created attachment 72698 [details] Patch
Simon Fraser (smfr)
Comment 3 2010-11-02 11:12:06 PDT
Comment on attachment 72698 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72698&action=review > WebCore/ChangeLog:10 > + "running" and not suspended. Likewise pauses animation when either > + flag is in the right state, There's an incomplete sentence here. > WebCore/page/animation/AnimationBase.cpp:1214 > + bool wantToBePaused = playState == AnimPlayStatePaused || m_compAnim->suspended(); 'wantToBePaused' confuses me. "shouldBePaused", or just "pause" perhaps? > LayoutTests/animations/play-state-suspend.html:83 > + runAnimationTest(expectedValues, setTimers, null, true); Please annotate the parameters, or use variables to make the purposes of 'null' and 'true' clear.
Chris Marrin
Comment 4 2010-11-02 13:48:29 PDT
Made changes suggested by Simon and landed in http://trac.webkit.org/changeset/71161
Note You need to log in before you can comment on or make changes to this bug.