Bug 45235 - [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
Summary: [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 45233
Blocks: 38656
  Show dependency tree / graph
 
Reported: 2010-09-04 15:46 PDT by Martin Robinson
Modified: 2010-09-06 08:17 PDT (History)
7 users (show)

See Also:

Attachments
Add modifier support to mouseDown and mouseUp (7.04 KB, patch)
2010-09-04 15:51 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-09-04 15:46:03 PDT 
The EventSender currently ignores modifier key arguments to these methods.
Comment 1 Martin Robinson 2010-09-04 15:51:17 PDT 
Created attachment 66592 [details]
Add modifier support to mouseDown and mouseUp
Comment 2 Xan Lopez 2010-09-04 23:42:13 PDT 
Comment on attachment 66592 [details]
Add modifier support to mouseDown and mouseUp

You sir are a gentleman and a scholar.
Comment 3 Martin Robinson 2010-09-06 07:44:50 PDT 
Comment on attachment 66592 [details]
Add modifier support to mouseDown and mouseUp

Clearing flags on attachment: 66592

Committed r66829: <http://trac.webkit.org/changeset/66829>
Comment 4 Martin Robinson 2010-09-06 07:44:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-09-06 08:17:24 PDT 
http://trac.webkit.org/changeset/66829 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/66827
http://trac.webkit.org/changeset/66828
http://trac.webkit.org/changeset/66829