RESOLVED WORKSFORME 38656
[GTK] [Qt] editing/selection/shift-click.html fails 
https://bugs.webkit.org/show_bug.cgi?id=38656
Summary [GTK] [Qt] editing/selection/shift-click.html fails
Ojan Vafai
Reported 2010-05-06 10:27:37 PDT
As best I can tell from looking at the test results, it looks like shift+click is getting treated as a regular click. Skipping the test for now.
Attachments
Patch (1.75 KB, patch)
2010-05-06 10:32 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2010-05-06 10:32:29 PDT
Created attachment 55257 [details] Patch
Adam Barth
Comment 2 2010-05-06 10:39:24 PDT
Comment on attachment 55257 [details] Patch Ok, but please follow up with some of the Qt/Gtk folks by email to make sure this is how they'd like this handled.
Ojan Vafai
Comment 3 2010-05-06 10:42:43 PDT
Committed r58896: <http://trac.webkit.org/changeset/58896>
Martin Robinson
Comment 4 2010-05-06 11:36:17 PDT
My intuition says this is related to the fact that GTK+ uses Mac editing behavior by default, but this test is checking the user-agent for Mac-specific strings.
Ojan Vafai
Comment 5 2010-05-06 13:41:42 PDT
(In reply to comment #4) > My intuition says this is related to the fact that GTK+ uses Mac editing > behavior by default, but this test is checking the user-agent for Mac-specific > strings. As best I can tell, that's not the case here. The test results don't match windows or mac editing behavior. They match the behavior of doing a regular click.
Martin Robinson
Comment 6 2010-05-06 13:57:49 PDT
There are some other bugs with GTK+ EventSender around double-clicks. I have one patch for it and will try to get it ready for review tomorrow. I wouldn't be surprised if it's failing both because Qt and GTK+ use the Mac editing style and because of bugs in DRT. I'll try to follow up when I have a moment.
Gustavo Noronha (kov)
Comment 7 2010-05-07 06:15:26 PDT
Coming from the email contact. I believe Martin is the GTK+ authority of choice for such issues, so I'll let him handle the case since he's already on it =D
Antonio Gomes
Comment 8 2010-06-09 21:22:08 PDT
test is still failing on Gtk and Qt. Reopening.
Eric Seidel (no email)
Comment 9 2010-09-02 13:54:30 PDT
Status?
Martin Robinson
Comment 10 2010-09-04 15:23:17 PDT
This patch is failing on GTK+ for two reasons: 1. There is no support in the EventSender for mouseUp and mouseDown modifiers. 2. The test uses the user-agent to figure out the editing style. I'll post patches soon.
Martin Robinson
Comment 11 2010-09-04 15:52:24 PDT
From a quick look, it appears that number 1 is also an issue with the Qt DRT.
Diego Gonzalez
Comment 12 2011-02-23 14:09:36 PST
Still reproducible at r79447
Martin Robinson
Comment 13 2015-05-07 16:47:32 PDT
This doesn't seem to be an issue any longer.
Note You need to log in before you can comment on or make changes to this bug.