Bug 45233 - Convert editing/selection/shift-click.html to use setEditingBehavior
Summary: Convert editing/selection/shift-click.html to use setEditingBehavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 38656 45235
  Show dependency tree / graph
 
Reported: 2010-09-04 15:36 PDT by Martin Robinson
Modified: 2010-09-06 08:17 PDT (History)
5 users (show)

See Also:

Attachments
Test conversion (6.93 KB, patch)
2010-09-04 15:39 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-09-04 15:36:51 PDT 
This test currently looks at the user-agent to figure out what the editing behavior should be. This patch tracks converting the test to test all editing styles and remove platform specific expected results.
Comment 1 Martin Robinson 2010-09-04 15:39:59 PDT 
Created attachment 66590 [details]
Test conversion
Comment 2 Antonio Gomes 2010-09-05 10:33:52 PDT 
Comment on attachment 66590 [details]
Test conversion

Perfect!
Comment 3 Martin Robinson 2010-09-06 07:42:45 PDT 
Comment on attachment 66590 [details]
Test conversion

Clearing flags on attachment: 66590

Committed r66828: <http://trac.webkit.org/changeset/66828>
Comment 4 Martin Robinson 2010-09-06 07:42:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-09-06 08:17:18 PDT 
http://trac.webkit.org/changeset/66828 might have broken Qt Linux Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/66827
http://trac.webkit.org/changeset/66828
http://trac.webkit.org/changeset/66829