Bug 44460 - REGRESSION(r65703): "Causing lots of crashes on Snow Leopard when running the layout tests" (Requested by eseidel2 on #webkit).
Summary: REGRESSION(r65703): "Causing lots of crashes on Snow Leopard when running the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 44270
  Show dependency treegraph
 
Reported: 2010-08-23 15:42 PDT by WebKit Review Bot
Modified: 2010-08-23 16:00 PDT (History)
3 users (show)

See Also:


Attachments
ROLLOUT of r65703 (4.43 KB, patch)
2010-08-23 15:42 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2010-08-23 15:42:19 PDT
http://trac.webkit.org/changeset/65703 broke the build:
"Causing lots of crashes on Snow Leopard when running the layout tests" (Requested by eseidel2 on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-08-23 15:42:31 PDT
Created attachment 65167 [details]
ROLLOUT of r65703

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Eric Seidel (no email) 2010-08-23 15:43:33 PDT
See https://lists.webkit.org/pipermail/webkit-dev/2010-August/013985.html for further discussion.
Comment 3 Eric Seidel (no email) 2010-08-23 15:44:38 PDT
jamesr suggests that bug 44298 may have been masking this (and other) Snow Leopard failure(s).
Comment 4 Eric Seidel (no email) 2010-08-23 15:45:54 PDT
A rollout here is not the right fix.  But this code is blocking several people from development, so rolling it out until Adam can roll it back in w/o SL crashes. :(
Comment 5 Eric Seidel (no email) 2010-08-23 15:59:59 PDT
Comment on attachment 65167 [details]
ROLLOUT of r65703

Clearing flags on attachment: 65167

Committed r65838: <http://trac.webkit.org/changeset/65838>
Comment 6 Eric Seidel (no email) 2010-08-23 16:00:05 PDT
All reviewed patches have been landed.  Closing bug.