Bug 44270 - Crash in NP_Initialize when loading QuickTime when running plugins/embed-attributes-setting.html in WebKit2 on Windows
Summary: Crash in NP_Initialize when loading QuickTime when running plugins/embed-attr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords: InRadar, PlatformOnly
Depends on: 44460
Blocks: 43189
  Show dependency treegraph
 
Reported: 2010-08-19 09:18 PDT by Adam Roben (:aroben)
Modified: 2010-08-25 11:14 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.13 KB, patch)
2010-08-19 09:19 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Patch (5.13 KB, patch)
2010-08-25 10:29 PDT, Adam Roben (:aroben)
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-08-19 09:18:18 PDT
Crash in NP_Initialize when loading QuickTime when running plugins/embed-attributes-setting.html in WebKit2 on Windows
Comment 1 Adam Roben (:aroben) 2010-08-19 09:19:01 PDT
Created attachment 64862 [details]
Patch
Comment 2 WebKit Review Bot 2010-08-19 09:21:11 PDT
Attachment 64862 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:37:  Missing space before ( in while(  [whitespace/parens] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Roben (:aroben) 2010-08-19 11:06:21 PDT
<rdar://problem/8330393>
Comment 4 Adam Roben (:aroben) 2010-08-19 14:26:48 PDT
Committed r65703: <http://trac.webkit.org/changeset/65703>
Comment 6 Eric Seidel (no email) 2010-08-23 15:48:29 PDT
Ha!  The sherriff even knew this change was at fault!  The buildbots were just so upset at the time it was hard to tell. :(
Comment 7 Adam Roben (:aroben) 2010-08-25 10:29:57 PDT
Created attachment 65434 [details]
Patch
Comment 8 WebKit Review Bot 2010-08-25 10:30:50 PDT
Attachment 65434 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:37:  Missing space before ( in while(  [whitespace/parens] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Adam Roben (:aroben) 2010-08-25 10:31:25 PDT
This new patch differs from the old one by recording when NP_Initialize is called and moving the Mac assertion into NP_GetEntryPoints. This allows NP_Initialize/NP_GetEntryPoints to be called multiple times (in the correct order) without the assertion firing.
Comment 10 Adam Roben (:aroben) 2010-08-25 11:14:07 PDT
Committed r66025: <http://trac.webkit.org/changeset/66025>