Bug 44298 - Failing the download step should make the build red
Summary: Failing the download step should make the build red
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-08-19 15:00 PDT by James Robinson
Modified: 2010-08-30 08:40 PDT (History)
2 users (show)

See Also:

Patch (1.45 KB, patch)
2010-08-29 19:01 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2010-08-19 15:00:16 PDT
Currently if a test slave's download step fails the build does not go red.  This makes it seems like the tests pass on the console view, which is quite dangerous.  For example on a recent run of the SnowLeopard Intel Release (WebKit2 tests) bot the download step failed with this stderr: "File 'archives/mac-snowleopard-x86_64-release/65706.zip' not available at master", but the results of the build was "build successful". http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/265
Comment 1 William Siegrist 2010-08-19 15:04:01 PDT
FileUpload and FileDownload steps default to not flunking the whole build if they fail. This should be just a 1 line change to add flunkOnFailure=True to DownloadBuiltProduct.
Comment 2 James Robinson 2010-08-29 19:01:28 PDT
Created attachment 65869 [details]
Comment 3 WebKit Commit Bot 2010-08-29 21:26:22 PDT
Comment on attachment 65869 [details]

Clearing flags on attachment: 65869

Committed r66353: <http://trac.webkit.org/changeset/66353>
Comment 4 WebKit Commit Bot 2010-08-29 21:26:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 William Siegrist 2010-08-30 08:40:42 PDT
Updated master. Graceful restart process has been kicked off.