Currently if a test slave's download step fails the build does not go red. This makes it seems like the tests pass on the console view, which is quite dangerous. For example on a recent run of the SnowLeopard Intel Release (WebKit2 tests) bot the download step failed with this stderr: "File 'archives/mac-snowleopard-x86_64-release/65706.zip' not available at master", but the results of the build was "build successful". http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/265
FileUpload and FileDownload steps default to not flunking the whole build if they fail. This should be just a 1 line change to add flunkOnFailure=True to DownloadBuiltProduct.
Created attachment 65869 [details]
Comment on attachment 65869 [details]
Clearing flags on attachment: 65869
Committed r66353: <http://trac.webkit.org/changeset/66353>
All reviewed patches have been landed. Closing bug.
Updated master. Graceful restart process has been kicked off.