Bug 42508 - [Qt] Render shadow when drawing one canvas onto another
Summary: [Qt] Render shadow when drawing one canvas onto another
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: HTML5, Qt, QtTriaged
: 42582 (view as bug list)
Depends on:
Blocks: 42510
  Show dependency tree / graph
 
Reported: 2010-07-17 17:35 PDT by Andreas Kling
Modified: 2010-07-19 12:43 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (4.25 KB, patch)
2010-07-17 17:37 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-07-17 17:35:10 PDT 
This test currently fails for Qt:
- canvas/philip/tests/2d.shadow.canvas.basic.html
Comment 1 Andreas Kling 2010-07-17 17:37:19 PDT 
Created attachment 61891 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2010-07-19 07:16:57 PDT 
Comment on attachment 61891 [details]
Proposed patch

LGTM. Any change in performance?
Comment 3 Andreas Kling 2010-07-19 07:21:27 PDT 
(In reply to comment #2)
> (From update of attachment 61891 [details])
> LGTM. Any change in performance?

If painting with a shadow, there is obviously a slight performance penalty. But no more painful than drawing something else with a shadow.
Comment 4 Andreas Kling 2010-07-19 07:24:44 PDT 
Comment on attachment 61891 [details]
Proposed patch

Clearing flags on attachment: 61891

Committed r63656: <http://trac.webkit.org/changeset/63656>
Comment 5 Andreas Kling 2010-07-19 07:24:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 qi 2010-07-19 12:43:13 PDT 
*** Bug 42582 has been marked as a duplicate of this bug. ***