RESOLVED FIXED 42508
[Qt] Render shadow when drawing one canvas onto another 
https://bugs.webkit.org/show_bug.cgi?id=42508
Summary [Qt] Render shadow when drawing one canvas onto another
Andreas Kling
Reported 2010-07-17 17:35:10 PDT
This test currently fails for Qt: - canvas/philip/tests/2d.shadow.canvas.basic.html
Attachments
Proposed patch (4.25 KB, patch)
2010-07-17 17:37 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-07-17 17:37:19 PDT
Created attachment 61891 [details] Proposed patch
Kenneth Rohde Christiansen
Comment 2 2010-07-19 07:16:57 PDT
Comment on attachment 61891 [details] Proposed patch LGTM. Any change in performance?
Andreas Kling
Comment 3 2010-07-19 07:21:27 PDT
(In reply to comment #2) > (From update of attachment 61891 [details]) > LGTM. Any change in performance? If painting with a shadow, there is obviously a slight performance penalty. But no more painful than drawing something else with a shadow.
Andreas Kling
Comment 4 2010-07-19 07:24:44 PDT
Comment on attachment 61891 [details] Proposed patch Clearing flags on attachment: 61891 Committed r63656: <http://trac.webkit.org/changeset/63656>
Andreas Kling
Comment 5 2010-07-19 07:24:54 PDT
All reviewed patches have been landed. Closing bug.
qi
Comment 6 2010-07-19 12:43:13 PDT
*** Bug 42582 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.