Bug 42510 - [Qt] Canvas: Wrong internal positioning of drawImage() shadows
Summary: [Qt] Canvas: Wrong internal positioning of drawImage() shadows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: HTML5, Qt, QtTriaged
Depends on: 42508
Blocks:
  Show dependency tree / graph
 
Reported: 2010-07-17 18:27 PDT by Andreas Kling
Modified: 2010-07-19 07:47 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (3.98 KB, patch)
2010-07-17 18:31 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-07-17 18:27:56 PDT 
There is a bug in the internal (in-shadow) positioning of shadows generated for drawImage().
They are offset by the the 'destination' rect twice.

This change fixes the following in-tree tests:
- canvas/philip/tests/2d.shadow.canvas.alpha.html
- canvas/philip/tests/2d.shadow.canvas.transparent.1.html
- canvas/philip/tests/2d.shadow.canvas.transparent.2.html
- canvas/philip/tests/2d.shadow.image.alpha.html
- canvas/philip/tests/2d.shadow.image.transparent.1.html
- canvas/philip/tests/2d.shadow.image.transparent.2.html
Comment 1 Andreas Kling 2010-07-17 18:31:51 PDT 
Created attachment 61894 [details]
Proposed patch

Note that this patch depends on bug 42508 for the drawImage(canvas, ...) part.
Comment 2 Andreas Kling 2010-07-19 07:28:02 PDT 
Comment on attachment 61894 [details]
Proposed patch

Clearing flags on attachment: 61894

Committed r63657: <http://trac.webkit.org/changeset/63657>
Comment 3 Andreas Kling 2010-07-19 07:28:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-07-19 07:47:39 PDT 
http://trac.webkit.org/changeset/63657 might have broken Qt Linux Release