Bug 41680 – [Qt] QtScript should provide an API for enumerating a JS object's properties

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Kent Hansen]

See http://doc.trolltech.com/latest/qscriptvalueiterator.html

[Jędrzej Nowacki]

Created attachment 61029 [details]
Fix v1

[WebKit Review Bot]

Attachment 61029 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/QtScript.pro"
JavaScriptCore/qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp:23:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
JavaScriptCore/qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp:24:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator.h"
WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator_p.h"
WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator.cpp"
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jędrzej Nowacki]

(In reply to comment #2)
> If any of these errors are false positives, please file a bug against check-webkit-style.

Bug 35151

[Kent Hansen]

(In reply to comment #1)
> Created an attachment (id=61029) [details]
> Fix v1

Looks good except for the "to" in "Introduce to QScriptValueIterator". And why the trailing comma in "arguments[] = { *m_object, };"?

[Jędrzej Nowacki]

Created attachment 61378 [details]
Fix v1.01

[WebKit Review Bot]

Attachment 61378 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/QtScript.pro"
JavaScriptCore/qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp:23:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
JavaScriptCore/qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp:24:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator.h"
WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator_p.h"
WARNING: File exempt from style guide. Skipping: "JavaScriptCore/qt/api/qscriptvalueiterator.cpp"
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 61378 [details]
Fix v1.01

Clearing flags on attachment: 61378

Committed r63233: <http://trac.webkit.org/changeset/63233>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.