Bug 35151 - check-webkit-style should ignore "config.h" rule inside Qt autotests
Summary: check-webkit-style should ignore "config.h" rule inside Qt autotests
Status: RESOLVED DUPLICATE of bug 53017
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-02-19 05:51 PST by Jędrzej Nowacki
Modified: 2011-02-25 00:41 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2010-02-19 05:51:28 PST 
check-webkit-style should ignore "config.h" rule inside directories:
JavaScriptCore/qt/tests/
WebKit/qt/tests/

These directories contain autotests, that are not part of the WebKit library and it is not possible to compile them with the include.

Use case: bug 34843
Comment 1 Tor Arne Vestbø 2010-03-10 06:42:11 PST 
Please follow the QtWebKit bug reporting guidelines when reporting bugs.

See http://trac.webkit.org/wiki/QtWebKitBugs

Specifically:

  - The 'QtWebKit' component should only be used for bugs/features in the
    public QtWebKit API layer, not to signify that the bug is specific to
    the Qt port of WebKit

      http://trac.webkit.org/wiki/QtWebKitBugs#Component

  - Add the keyword 'Qt' to signal that it's a Qt-related bug

      http://trac.webkit.org/wiki/QtWebKitBugs#Keywords
Comment 2 Zoltan Horvath 2011-02-25 00:41:45 PST 
check-webkit-style ignores these, see r76530 
(http://trac.webkit.org/changeset/76530/trunk/Tools/Scripts/webkitpy/style/checker.py)

*** This bug has been marked as a duplicate of bug 53017 ***