Bug 40184 - Remove side effects of form submission and prepare FormDataBuilder for splitting up.
Summary: Remove side effects of form submission and prepare FormDataBuilder for splitt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on: 40137
Blocks: 40893
  Show dependency tree / graph
 
Reported: 2010-06-04 13:15 PDT by Dimitri Glazkov (Google)
Modified: 2010-06-22 08:56 PDT (History)
0 users

See Also:

Attachments
Patch (13.08 KB, patch)
2010-06-04 13:28 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
Patch (13.14 KB, patch)
2010-06-21 16:32 PDT, Dimitri Glazkov (Google) 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2010-06-04 13:15:55 PDT 
Remove side-effects of form submission and prepare FormDataBuilder for splitting up.
Comment 1 Dimitri Glazkov (Google) 2010-06-04 13:28:01 PDT 
Created attachment 57909 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-06-21 16:32:56 PDT 
Created attachment 59309 [details]
Patch
Comment 3 Darin Adler 2010-06-21 22:16:31 PDT 
Comment on attachment 59309 [details]
Patch

> +            m_formDataBuilder.parseEncodingType("application/x-www-form-urlencoded");

Why is it important to call the parse function instead of the set function here?

r=me
Comment 4 Dimitri Glazkov (Google) 2010-06-22 08:54:45 PDT 
(In reply to comment #3)
> (From update of attachment 59309 [details])
> > +            m_formDataBuilder.parseEncodingType("application/x-www-form-urlencoded");
> 
> Why is it important to call the parse function instead of the set function here?

That's actually a good question and points to a problem that I'll figure out how to solve. parseEncodingType sets isMultiPart to false, which is still kind of side-effecty. See assert right next to this statement.

> 
> r=me
Comment 5 Dimitri Glazkov (Google) 2010-06-22 08:56:39 PDT 
Committed r61618: <http://trac.webkit.org/changeset/61618>