Bug 40137 - Plumb FormSubmission through to ScheduledFormSubmission.
Summary: Plumb FormSubmission through to ScheduledFormSubmission.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on: 40084
Blocks: 40184
  Show dependency treegraph
 
Reported: 2010-06-03 13:55 PDT by Dimitri Glazkov (Google)
Modified: 2010-06-21 10:54 PDT (History)
1 user (show)

See Also:


Attachments
Patch (19.51 KB, patch)
2010-06-03 14:09 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Patch (19.57 KB, patch)
2010-06-20 15:17 PDT, Dimitri Glazkov (Google)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2010-06-03 13:55:17 PDT
Plumb FormSubmission through to ScheduledFormSubmission.
Comment 1 Dimitri Glazkov (Google) 2010-06-03 14:09:25 PDT
Created attachment 57811 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-06-20 15:17:13 PDT
Created attachment 59218 [details]
Patch
Comment 3 Dimitri Glazkov (Google) 2010-06-20 15:20:22 PDT
... and one more!

Here I just basically plumb FormSubmission further in (not quite to the very end), and move some of the logic to more logical places :)
Comment 4 Darin Adler 2010-06-20 22:15:55 PDT
Comment on attachment 59218 [details]
Patch

> +#include "KURL.h"
>  #include "PlatformString.h"
>  #include <wtf/Forward.h>
>  #include <wtf/RefCounted.h>

You probably don't need to include anything else if you include "KURL.h". I believe that includes all those other headers.

> +    void populateFrameLoadRequest(FrameLoadRequest&);

This should be a const member function.

> +    void setReferrer(String referrer) { m_referrer = referrer; }

> +    void setOrigin(String origin) { m_origin = origin; }

The arguments to these functions should be const String& rather than String.

r=me
Comment 5 Dimitri Glazkov (Google) 2010-06-21 10:54:04 PDT
(In reply to comment #4)
> (From update of attachment 59218 [details])
> > +#include "KURL.h"
> >  #include "PlatformString.h"
> >  #include <wtf/Forward.h>
> >  #include <wtf/RefCounted.h>
> 
> You probably don't need to include anything else if you include "KURL.h". I believe that includes all those other headers.
> 
> > +    void populateFrameLoadRequest(FrameLoadRequest&);
> 
> This should be a const member function.

Not yet -- I still have to modify m_action there. But we're getting there :)

> 
> > +    void setReferrer(String referrer) { m_referrer = referrer; }
> 
> > +    void setOrigin(String origin) { m_origin = origin; }
> 
> The arguments to these functions should be const String& rather than String.

Done.

> 
> r=me

Landed as http://trac.webkit.org/changeset/61546.