RESOLVED FIXED 39740
[style] Allow usage of NULL in gst_*_many() 
https://bugs.webkit.org/show_bug.cgi?id=39740
Summary [style] Allow usage of NULL in gst_*_many()
Philippe Normand
Reported 2010-05-26 08:29:30 PDT
The cpp style-checker shouldn't warn about usage of NULL in gst_*_many() calls. It can't be replaced by 0, see also Bug 32858.
Attachments
proposed patch (2.76 KB, patch)
2010-05-26 08:40 PDT, Philippe Normand 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-05-26 08:40:38 PDT
Created attachment 57100 [details] proposed patch
David Levin
Comment 2 2010-05-26 13:54:45 PDT
Comment on attachment 57100 [details] proposed patch I wonder if it should just be gst_* Care to fix: https://bugs.webkit.org/show_bug.cgi?id=39372 ? (The problem there was g_build_filename. I wonder if the g_ checks should be broadened to g_*).
Philippe Normand
Comment 3 2010-05-27 00:21:34 PDT
(In reply to comment #2) > (From update of attachment 57100 [details]) > I wonder if it should just be gst_* > AFAICT it should be enough with gst_*_many. If really needed we can extend this later on, meanwhile I will land this patch :) > Care to fix: https://bugs.webkit.org/show_bug.cgi?id=39372 ? > (The problem there was g_build_filename. I wonder if the g_ checks should be broadened to g_*). Yes it sounds like a good idea, I will tackle the bug above when I get time :)
Philippe Normand
Comment 4 2010-05-27 02:22:59 PDT
Landed in http://trac.webkit.org/changeset/60283 Thanks!
Note You need to log in before you can comment on or make changes to this bug.