Bug 39472 – [GStreamer] multiple video sink support

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Philippe Normand]

For video fullscreen support it would be nice if the player could do the rendering using autovideosink. This requires the current playbin2 video-sink to be a bin internally rendering to the webkit videosink and, when needed for fullscreen, autovideosink.

For this to work on application-side, gst XOverlay support is also needed in GStreamerGWorld, otherwise autovideosink (on gtk port) will internally create and show an X11 window.

[Philippe Normand]

Created attachment 57337 [details]
proposed patch

[Philippe Normand]

Sebastian, can you have a look at the patch when you get some time please? :)

[Sebastian Dröge (slomo)]

Looks good, yes

[Philippe Normand]

Gustavo, would you have time to take a look? Bug 39474 too if possible. Sebastian  did one pass on the patches already, some time ago :)

[Gustavo Noronha (kov)]

Comment on attachment 57337 [details]
proposed patch

It looks very good to me. The only improvement I suggest is not creating member variables for the queue and the tee. They are completely useless - you are not even using them when enabling fullscreen, so just make them variables scoped to the createGSTPlayBin function, please, unless you have a good reason to keep them. I would prefer having more descriptive names for the queue and tee elements, too "t" does the job, but we can do better, I guess? =)

[Philippe Normand]

Landed as http://trac.webkit.org/changeset/61834 with the suggested fixes. Thanks for the review :)